Add more TS tests for pallet-xcm precompile #3107
Merged
+502
−126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Agusrodri
added
B0-silent
WASM runtime size check:Compared to target branchMoonbase runtime: 2276 KB (no changes) ✅ Moonbeam runtime: 2248 KB (no changes) ✅ Moonriver runtime: 2244 KB (no changes) ✅ Compared to latest release (runtime-3400)Moonbase runtime: 2276 KB (+248 KB compared to latest release) Moonbeam runtime: 2248 KB (+236 KB compared to latest release) Moonriver runtime: 2244 KB (+232 KB compared to latest release) |
Coverage Report@@ Coverage Diff @@
## master agustin-xcm-precompile-tests +/- ##
===============================================================
Coverage 74.49% 74.49% 0.00%
Files 375 375
Lines 95313 95313
===============================================================
Hits 70998 70998
Misses 24315 24315
|
RomarQ
reviewed
Dec 17, 2024
test/suites/dev/moonbase/test-precompile/test-precompile-pallet-xcm-2.ts
Outdated
Show resolved
Hide resolved
RomarQ
requested changes
Dec 17, 2024
RomarQ
added
B7-runtimenoteworthy
RomarQ
previously approved these changes
Dec 20, 2024
RomarQ
previously approved these changes
Dec 20, 2024
gonzamontiel
previously approved these changes
Dec 30, 2024
test/suites/dev/moonbase/test-precompile/test-precompile-pallet-xcm-2.ts
Show resolved
Hide resolved
test/suites/dev/moonbase/test-precompile/test-precompile-pallet-xcm-2.ts
Outdated
Show resolved
Hide resolved
pLabarta
reviewed
Jan 2, 2025
| .polkadotJs() | ||
| .tx.sudo.sudo(mockHrmpChannelExistanceTx(context, destinationPara, 1000, 102400, 102400)); | ||
|
|
||
| const alithNonce = ( |
There was a problem hiding this comment.
Is there a reason to manually fetch Alith's current nonce? The test runs correctly without passing the nonce to createThersTransaction.
| functionName: "transferAssetsToPara20", | ||
| }), | ||
| gasLimit: 500_000n, | ||
| nonce: alithNonce, |
There was a problem hiding this comment.
Same as the previous comment
| [await foreignParaAssetContract.getAddress(), amountToSend], | ||
| ]; | ||
|
|
||
| const mockHrmp1000Tx = context |
There was a problem hiding this comment.
Can we mock the channel once at beforeAll instead of every case?
pLabarta
reviewed
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Adds extra typescript tests for pallet-xcm precompile. The new tests mostly check the behavior at the moment of combining two assets, and also using the origin's chain native token to pay for fees.